[박수훈] sprint7#78
Open
mdeeno wants to merge 22 commits intocodeit-sprint-fullstack:react-박수훈from
Hidden character warning
The head ref may contain hidden characters: "react-\ubc15\uc218\ud6c8-sprint7"
Open
Conversation
- 상품 등록 유효성 검사 (Custom Hook) 및 태그 칩 기능 구현 - 상품 등록 페이지 반응형 레이아웃(Mobile/Tablet/PC) 적용 - Header 및 RegistrationPage CSS 파일 분리 (스타일 충돌 해결) - App.jsx 상세 페이지 라우팅 오류 수정
mdeeno
added
매운맛🔥
mdeeno
added
최종제출
wseungjin
approved these changes
Feb 25, 2026
| const response = await fetch(`${BASE_URL}/products?${query}`); | ||
|
|
||
| if (!response.ok) { | ||
| throw new Error(`데이터 로딩 실패: ${response.status}`); |
Collaborator
There was a problem hiding this comment.
실패해서 에러 던지면 서버에서 html을 send해줄 수 있나요?
예외처리가 필요하지 않을까요?
| // (구 signup.html) 회원가입 화면 ('/signup') | ||
|
|
||
| import Link from 'next/link'; | ||
| import '../../../styles/Login.css'; |
Collaborator
There was a problem hiding this comment.
alias나 ../../../를 지양하면 좋을거 같네요
| const [content, setContent] = useState(''); | ||
|
|
||
| useEffect(() => { | ||
| const loadArticle = async () => { |
Collaborator
There was a problem hiding this comment.
훅으로 빼는건 어떨까요?
로딩, 에러를 추가해보는건 어떨까요?
서버컴포넌트로 뺼 여지도 좀 있는거 같은데 그런 부분도 고민해보세요
| const API_URL = process.env.NEXT_PUBLIC_API_URL || 'http://localhost:5001/api'; | ||
|
|
||
| // 상대 시간 변환 함수 | ||
| const getRelativeTime = (dateString) => { |
Collaborator
There was a problem hiding this comment.
이런건 시간 utils로 빼도 좋을거 같아요
| createComment, | ||
| updateComment, | ||
| deleteComment, | ||
| } from '../../../../../api/api'; |
Collaborator
There was a problem hiding this comment.
왜 api폴더 안에 api파일이 있는걸까요?
index로도 충분해보입니다.
|
|
||
| // 1. 유효성 검사 규칙 (심화 요구사항 반영) | ||
| // - 상품명: 10자 이내 | ||
| const validateName = (val) => { |
Collaborator
There was a problem hiding this comment.
val보다는 그냥 name이 들어오면 좋을거 같아요
| !priceInput.error; | ||
|
|
||
| // 5. 제출 핸들러 | ||
| const handleSubmit = async (e) => { |
Collaborator
There was a problem hiding this comment.
form 관련 로직만 전부 커스텀 훅으로 뺴보는건 어떨까요?
| import styles from '../App.module.css'; | ||
|
|
||
| const BestProductList = () => { | ||
| const [bestProducts, setBestProducts] = useState([]); |
Collaborator
There was a problem hiding this comment.
로딩, 에러 상태가 들어가면 좋을거 같아요 + 커스텀 훅도요
| const [totalCount, setTotalCount] = useState(0); | ||
| const [order, setOrder] = useState('recent'); | ||
| const [keyword, setKeyword] = useState(''); | ||
| const [page, setPage] = useState(1); |
Collaborator
There was a problem hiding this comment.
page말고 index 써주시고 0부터 해주시면 더 좋을거 같아요
|
|
||
| const ProductList = () => { | ||
| const [products, setProducts] = useState([]); | ||
| const [totalCount, setTotalCount] = useState(0); |
Collaborator
There was a problem hiding this comment.
totalCount가 따로 필요한가요?
products.length를 사용하면 안되나요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 스프린트 미션 요구사항
기본 요구사항
공통
자유 게시판 페이지
게시글 등록 & 수정 페이지
게시글 상세 페이지
심화 요구사항
공통
2. 주요 변경사항
3. 멘토님에게 남길 메시지